perf: improve performance of facet providers #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pollend
commented
Feb 23, 2021
|
|
||
| for (Vector3ic pos : facet.getWorldRegion()) { | ||
| float depth = elevationFacet.getWorld(pos.x(), pos.z()) - pos.y(); | ||
| float frequencyReduction = (float) Math.max(0, 0.3 - Math.max(depth, 0) / 400); //0: no reduction, 0.7: pretty much no caves. Also somewhat increases the tendency of caves to loop rather than continuing indefinitely. | ||
| int i = facet.getWorldIndex(pos); | ||
| float noiseValue = (float) Math.hypot(caveNoiseValues[0][i], caveNoiseValues[1][i]+frequencyReduction); |
There was a problem hiding this comment.
this is significantly slower.
pollend
changed the title
skaldarnar
reviewed
Feb 23, 2021
| for (int x = -1; x <= 1; x++) { | ||
| for (int z = -1; z <= 1; z++) { | ||
| Vector3i belowPos = new Vector3i(pos.x + x, pos.y - 1, pos.z + z); | ||
| Vector3i belowPos = new Vector3i(pos.x() + x, pos.y() - 1, pos.z() + z); |
There was a problem hiding this comment.
you could reuse a tmp vector here if I see it correctly
Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
skaldarnar
approved these changes
Feb 24, 2021
skaldarnar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here are some minor improvements to improve cave generation. A Hashset does not seem ideal in this case especially when we can take advantage of locality. Math.hypot seems really expensive what I was looking at and reduced some of GC for that hashset that was used.