Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make ChangingBlocks case insensitive via BlockUri #15

Merged
merged 8 commits into from Aug 23, 2022
Merged

fix: make ChangingBlocks case insensitive via BlockUri #15

merged 8 commits into from Aug 23, 2022

Commits on Aug 15, 2022

  1. feat: make ChangingBlocks case insensitive via SimpleUri 

    - before this PR, a prefab specifying the `ChangingBlocks` component had to make sure that the keys in the `blockFamilyStages` map match the string representation of the respective `BlockUri`s including case
  example for a mismatch: `PlantPack:Corn1` (as referenced in `PlantPack:Corn.prefab`) != `PlantPack:corn1` (in-game `BlockUri` of `PlantPack:Corn1.block`)
- by sanitizing the reference in the `ChangingBlocks` component via the `SimpleUriTypeHandler` and comparing it with the `SimpleUri` derived from the in-game `BlockUri`, the logic becomes case insensitive
    @jdrueckert
    jdrueckert committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    a5d6d13 View commit details
    Browse the repository at this point in the history

  2. chore: update copyright

    @jdrueckert
    jdrueckert committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    765e649 View commit details
    Browse the repository at this point in the history

  3. chore: fix checkstyle findings 

    - line length
- missing whitespaces
- copyright updates
    @jdrueckert
    jdrueckert committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    2297a31 View commit details
    Browse the repository at this point in the history

  4. chore: align sample component map formatting

    @jdrueckert
    jdrueckert committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    78fe822 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2022

  1. doc: fix sample prefab indentation

    @jdrueckert
    jdrueckert committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    40182c6 View commit details
    Browse the repository at this point in the history

  2. chore: fix spotbugs findings

    @jdrueckert
    jdrueckert committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    61af268 View commit details
    Browse the repository at this point in the history

  3. chore: extract BlockUri to SimpleUri logic into helper method

    @jdrueckert
    jdrueckert committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    54773d5 View commit details
    Browse the repository at this point in the history

  4. feat: use BlockUri instead of SimpleUri

    @jdrueckert
    jdrueckert committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    af4803f View commit details
    Browse the repository at this point in the history