feature(ecs-gestalt): Migrate Components to gestalt's Components #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
commented
Jul 12, 2021
| @Replicate | ||
| public FactionList faction = PlanetFactionList.EARTH; | ||
|
|
||
| @Override | ||
| public void copy(FactionComponent other) { | ||
| this.faction = other.faction; |
There was a problem hiding this comment.
FactionList is just an interface 🤔 not sure how to do a deep copy of instances of that in the end ... not even sure what the design decision here was...
Comment on lines
10
to
12
| public RandomDamageComponent() { | ||
|
|
||
| } |
There was a problem hiding this comment.
No need to add the default constructor here if there are no other constructors.
Suggested change
| public RandomDamageComponent() { | |
| } |
src/main/java/org/terasology/combatSystem/physics/components/GravityComponent.java
Show resolved
Hide resolved
Comment on lines
8
to
13
| public class ActivateOnPlaceComponent implements Component<ActivateOnPlaceComponent> { | ||
|
|
||
| @Override | ||
| public void copy(ActivateOnPlaceComponent other) { | ||
|
|
||
| } |
There was a problem hiding this comment.
This should just extend EmptyComponent.
|
|
||
| public class PrimaryAttackComponent implements Component<PrimaryAttackComponent> { |
There was a problem hiding this comment.
Should extend EmptyComponent
|
|
||
| public class SecondaryAttackComponent implements Component{ | ||
| public class SecondaryAttackComponent implements Component<SecondaryAttackComponent> { |
There was a problem hiding this comment.
Should extend EmptyComponent.
|
|
||
| @Override | ||
| public void copy(AddSwitchDoorsComponent other) { | ||
| this.doorsToSpawn = Lists.newArrayList(other.doorsToSpawn); |
There was a problem hiding this comment.
For a deep copy we should create copies of DoorsToSpawn (or investigate whether we can make it immutable instead).
This change is only local to this module in an Omega workspace.
jdrueckert
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: MovingBlocks/Terasology#4753