-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ecs-gestalt): Migrate Components to gestalt's Components. #10
Conversation
this.monitorSize = other.monitorSize; | ||
this.front = other.front; | ||
this.mode = other.mode; | ||
this.data = Lists.newArrayList(data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change the constructor to use addAll
, why not .clear()
and .addAll(other.data)
here?
Also, there's a bug in there as it should at least be
this.data = Lists.newArrayList(data); | |
this.data = Lists.newArrayList(other.data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like so?
this.monitorSize.set(other.monitorSize); | ||
this.front = other.front; | ||
this.mode = other.mode; | ||
this.data = Lists.newArrayList(other.data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like so?
src/main/java/org/terasology/computer/display/component/DisplayComponent.java
Outdated
Show resolved
Hide resolved
…yComponent.java Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
Ref: MovingBlocks/Terasology#4753