chore: fix checkstyle warnings #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
skaldarnar
commented
Aug 28, 2021
skaldarnar
commented
- chore: update copyright
- chore: fix various checkstyle warnings
- chore: fix checkstyle warnings in MultiInvStorageHandler
skaldarnar
added
the
Type: Chore
skaldarnar
commented
Aug 28, 2021
| if (amount == 0) { | ||
| inventoryManager.giveItem(chest, EntityRef.NULL, item); | ||
|
|
||
| remaining -= byteAmount; |
There was a problem hiding this comment.
before we subtracted the full amountForChest here. Looking at the code, I believe this was a potential bug, as we only give byteAmount many items to the chest.
skaldarnar
force-pushed
the
chore/fix-checkstyle-warnings
branch
from
e3bf6b2
to
bc892fb
Compare
jdrueckert
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.