test: add basic pathfinding test cases #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrueckert
added
Type: Improvement
skaldarnar
reviewed
Feb 13, 2022
src/test/java/org/terasology/flexiblepathfinding/FallingJPSTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/terasology/flexiblepathfinding/LeapingJPSTest.java
Outdated
Show resolved
Hide resolved
| package org.terasology.flexiblepathfinding.helpers; | ||
|
|
||
| public final class TestPaths { | ||
| public static final String[] singleFlatStepNorthPath = { |
There was a problem hiding this comment.
Checkstyle wants you to write this as
Suggested change
| public static final String[] singleFlatStepNorthPath = { | |
| public static final String[] SINGLE_FLAT_STEP_NORTH_PATH= { |
not sure this is better... maybe we should disable checkstyle for the whole file?
Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
- add documentation to WalkingJPSTest - add positive test case to LeapingJPSTest and FallingJPSTest - fix checkstyle issues
skaldarnar
approved these changes
Feb 13, 2022
jdrueckert
changed the title
skaldarnar
added a commit
to Terasology/Behaviors
that referenced
this pull request
Mar 13, 2022
- style: format `.behavior` files - chore: add TODO ideas and questions in several places - chore: add some debug logging - feature/fix: small adjustments to Behaviors logic Follow-up PR to #89. Related PRs (extracted from this): #94, #96, #97, #99. Contributes to MovingBlocks/Terasology#4981. Depends on Terasology/FlexiblePathfinding#26 and Terasology/FlexiblePathfinding#27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract many tests cases from Terasology/Behaviors#92 to tests on the pathfinding itself.
Most importantly, this allows us to run these tests as unit tests instead of long-running integration tests using MTE.