Block Damage systems #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-aakash
commented
May 25, 2019
| @Override | ||
| public void renderOverlay() { | ||
| if (blockSelectionRenderer == null) { | ||
| Texture texture = Assets.getTextureRegion("health:blockdamageeffects#1").get().getTexture(); |
There was a problem hiding this comment.
Even though the BlockDamageEffects has been moved into the module, this line is creating NoSuchElementException.
syntaxi
reviewed
May 30, 2019
| { | ||
| "location": {}, | ||
| "particleDataSprite": { | ||
| "texture": "core:fx_smoke" |
There was a problem hiding this comment.
This will need to be changed to "health:fx_smoke" and the file should be duplicated to health because I'm fairly sure that there are other modules that use it.
deltas/engine/prefabs/test.prefab
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "RigidBody": { | |||
| "kinematic": false | |||
There was a problem hiding this comment.
Should this file still be here?
There was a problem hiding this comment.
I don't think this is required, so will remove it.
iaronaraujo
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds required assets and system for functioning of damage to blocks.
How to test:
BuilderSampleGameplaytemplate withHealthModule activated in advanced settings