fix: retrieve character entity within binding #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #45 the character entity was cached outside of the binding evaluation. However, it in multiplayer games it can happen that it is `null`, and therefore opening container screens on a connected client fails. This is fixed by retrieving the character entity with each binding evaluation via a common helper method `getPredictedInteractionTarget`.
skaldarnar
added
Multiplayer
jdrueckert
approved these changes
Aug 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #45 the character entity was cached outside of the binding evaluation. However, it in multiplayer games it can happen that it is
null, and therefore opening container screens on a connected client fails.This is fixed by retrieving the character entity with each binding evaluation via a common helper method
getPredictedInteractionTarget.