Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player Statistics Implementation #92

Merged
merged 6 commits into from Jun 20, 2019
Merged

Player Statistics Implementation #92

merged 6 commits into from Jun 20, 2019

Conversation

darshan3
Copy link
Member

Project Cards:

  1. Game Stats System

How to test:

  1. Host a Light and Shadow game
  2. Join the game using one more client instance
  3. Choose one team with each of the players
  4. Play the game! Kill each other, capture the flags
  5. The player to collect the flag 5 times first wins!

Expected outcome:
The game over screen should now show a list of all players and their kills and deaths.

@darshan3 darshan3 mentioned this pull request Jun 16, 2019
Closed
@darshan3 darshan3 added this to In progress in GSOC 2019: Light & Shadows Jun 16, 2019
@darshan3
Copy link
Member Author

Currently, the statistics should be displayed twice for the server/client instance but that is due to an event being sent twice, and it is handled in pr #91.

iaronaraujo
iaronaraujo approved these changes Jun 16, 2019
View reviewed changes
Copy link
Contributor

@iaronaraujo iaronaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved!

nihal111
nihal111 approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@nihal111 nihal111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Haven't tested out locally yet, merging on priority.

In-game statistics bound to a key would be good to have in the future. Maybe even extending the online player list (F2) would work?

@nihal111 nihal111 merged commit 41645e3 into master Jun 20, 2019
GSOC 2019: Light & Shadows automation moved this from In progress to Done Jun 20, 2019
@skaldarnar skaldarnar deleted the Statistics branch October 18, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iaronaraujo iaronaraujo iaronaraujo approved these changes

@nihal111 nihal111 nihal111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
GSOC 2019: Light & Shadows
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@darshan3 @iaronaraujo @nihal111