Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Statistics Implementation #92

Merged
merged 6 commits into from Jun 20, 2019

Conversation

@darshan3
Copy link
Member

commented Jun 16, 2019

Project Cards:

  1. Game Stats System

How to test:

  1. Host a Light and Shadow game
  2. Join the game using one more client instance
  3. Choose one team with each of the players
  4. Play the game! Kill each other, capture the flags
  5. The player to collect the flag 5 times first wins!

Expected outcome:
The game over screen should now show a list of all players and their kills and deaths.

@darshan3

This comment has been minimized.

Copy link
Member Author

commented Jun 16, 2019

Currently, the statistics should be displayed twice for the server/client instance but that is due to an event being sent twice, and it is handled in pr #91.

@iaronaraujo
Copy link
Contributor

left a comment

Tested and approved!

@nihal111
Copy link
Member

left a comment

LGTM. Haven't tested out locally yet, merging on priority.

In-game statistics bound to a key would be good to have in the future. Maybe even extending the online player list (F2) would work?

@nihal111 nihal111 merged commit 41645e3 into master Jun 20, 2019

GSOC 2019: Light & Shadows automation moved this from In progress to Done Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.