Disabled mode for restart button #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefaniamak
suggested changes
Sep 15, 2020
There was a problem hiding this comment.
Tested it out alongside Terasology/LightAndShadow#161 (review) and it works as expected 👍
I just want to suggest you making the letters slightly darker, so change the "E8E8E8" part of the color, with a darker grey HEX number :)
|
Also another note about making PRs: it's always nice to show a screenshot of your changes (especially when it is a UI change), so when reviewing we can be sure we saw what we expected to see! |
|
|
1 task
|
I think it looks cool, yes! |
|
Done. |
stefaniamak
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Part of Terasology/LightAndShadow#161 and adds the disabled mode to the UIButton which has to be used for the restart button.
How to test
Join a single player or multiplayer game and when the game is over, for the first 10 seconds the disabled mode of the refresh button will be visible.
Outstanding before merging