feat: improve EnemySpawnSystem
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jdrueckert
commented
Oct 20, 2020
jdrueckert
commented
- might fix a potential issue with despawning MawGooeys
- only spawn enemies if there's less than the max number present (instead of always spawning and removing if above max)
- spawn periodically based on elapsed time rather than game ticks (cpu-dependent)
- might fix a potential issue with despawning MawGooeys - only spawn enemies if there's less than the max number present (instead of always spawning and removing if above max) - spawn periodically based on elapsed time rather than game ticks (cpu-dependent)
jdrueckert
added
the
Type: Improvement
skaldarnar
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
This changes the logic a bit - we no longer spawn new enemies in each update period, but only if there is still some space left in our queue. Cleanup of inactive enemy entities still happens, so hopefully moving to different chunks will cause a clean up and new mobs to spawn.
We may want to track more information about the mobs in the future to allow for despawning if "not gameplay relevant", and prevent despawning of "relevant" mobs (e.g., currently in a fight).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.