chore: refactor Region to GraphRegion
#26
Conversation
There was a problem hiding this comment.
Hi @Wdestroier,
thanks for the PR.
I believe you missed a few spots though. For instance, LevelSpawnSystem still imports org.terasology.polyworld.graph.Region which, expectedly, it cannot find anymore now.
Please adjust these spots as well 🙂
|
Hi! @jdrueckert I found the LevelSpawnSystem class in the org.terasology.lost package, am I missing any dependency? |
|
@Wdestroier Yes you're absolutely right, sorry about that, my brain must be a bit gooey already 🙄 |
|
So we had another potential contributor ask for taking #24 (ping @gaurav9822). I mentioned that they maybe can take on the |
| @@ -102,11 +102,11 @@ public Vector3f getSpawnPosition(EntityRef entity) { | |||
| GraphFacet graphs = worldRegion.getFacet(GraphFacet.class); | |||
| WhittakerBiomeModelFacet model = worldRegion.getFacet(WhittakerBiomeModelFacet.class); | |||
| Vector2f pos2d = new Vector2f(pos.getX(), pos.getZ()); | |||
| CirclePickerClosest<org.terasology.polyworld.graph.Region> picker = new CirclePickerClosest<>(pos2d); | |||
| CirclePickerClosest<org.terasology.polyworld.graph.GraphRegion> picker = new CirclePickerClosest<>(pos2d); | |||
There was a problem hiding this comment.
This should now be possible without the fully qualified name (as there is no name clash anymore)
| CirclePickerClosest<org.terasology.polyworld.graph.GraphRegion> picker = new CirclePickerClosest<>(pos2d); | |
| CirclePickerClosest<GraphRegion> picker = new CirclePickerClosest<>(pos2d); |
This change would likely need an import, though.
|
|
||
| for (Graph g : graphs.getAllGraphs()) { | ||
| BiomeModel biomeModel = model.get(g); | ||
| for (org.terasology.polyworld.graph.Region r : g.getRegions()) { | ||
| for (org.terasology.polyworld.graph.GraphRegion r : g.getRegions()) { |
There was a problem hiding this comment.
| for (org.terasology.polyworld.graph.GraphRegion r : g.getRegions()) { | |
| for (GraphRegion r : g.getRegions()) { |
Hi! I solved the name clash and changed the Region class name to GraphRegion as suggested.
Note: On merging this,
Lost's references toPolyWorld::Regionwill break and need to be adjusted toGraphRegion.