Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HealEffects to depend on restoration logic #53

Merged
merged 2 commits into from Aug 12, 2019

Conversation

e-aakash
Copy link
Member

@e-aakash e-aakash commented Jun 22, 2019

Change DoHealEvent to DoRestoreEvent.

How to test:

  1. Checkout PR Health Overhaul MovingBlocks/Terasology#3677 branch
  2. Checkout PR Add javadoc to restore events and RestorationAuthoritySystem Health#17 in Health module.
  3. Start a new game with Potions and Core (which will add Health).
  4. Console command setRegenRate 0, so that regeneration does not affect testing restoration
  5. Console command damage 90 to cause damage to player.
  6. Test heal potions:
    i. Console command give Potions:HealPotion, activate the potion. Health restores by 20
    ii. Console command give Potions:SuperHealPotion, activate the potion. Full health restored
    iii. Console command give Potions:UltraHealPotion, activate the potion. Full health restored

@syntaxi
Copy link
Member

syntaxi commented Jun 29, 2019

Nice and simple changes, and the other touch ups are good as well. Ready to merge whenever

@syntaxi syntaxi marked this pull request as ready for review August 12, 2019 17:33
@syntaxi syntaxi merged commit 318774a into Terasology:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants