Fix for Thirst related Alive/Death handling #5
Conversation
nihal111
changed the title
|
It looks good to me! Thanks for the corrections and formatting changes as well. |
| thirst.lastCalculatedWater = ThirstUtils.getThirstForEntity(entity); | ||
| public void onPlayerRespawn(OnPlayerRespawnedEvent event, EntityRef player, | ||
| ThirstComponent thirst) { | ||
| logger.info("mark"); |
There was a problem hiding this comment.
stray logging statement feels lonely 😢
| resetThirst(player, thirst); | ||
| } | ||
|
|
||
| private void resetThirst(EntityRef player, ThirstComponent thirst) { |
There was a problem hiding this comment.
Would it make sense to expose the resetThirst functionality as event + handler? That way, another module could modify the behavior in case a player respawns after death. For instance, start only with half the thirst meter in general, and only respawn with full thirst meter if you have some item equipped.
There was a problem hiding this comment.
Seems sensible, although it may get lost on this closed PR. Maybe better to submit as an enhancement request issue :-)
There was a problem hiding this comment.
That'd seem interesting @skaldarnar @Cervator. I'd suggest submitting an issue with this idea.
Fix for MovingBlocks/Terasology#3003