Retire piecelists #175
Merged
Retire piecelists #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The piecelist is an old relic inherited from VICE. Now with a full bitboard representation they add nothing in terms of functionality. In Stockfish they supposedly improve move ordering slightly, preventing their removal, but in Weiss they are not used for anything the bitboards can't do identically. Using them for movegen like in SF resulted in a regression, so there is no reason to keep them around.
Retires the piecelists, and refactors the code that relied on them. This results in a speedup.
No functional change.
ELO | 6.05 +- 4.62 (95%)
SPRT | 10.0+0.1s Threads=1 Hash=32MB
LLR | 2.99 (-2.94, 2.94) [0.00, 5.00]
Games | N: 13148 W: 4097 L: 3868 D: 5183
http://chess.grantnet.us/viewTest/4624/
Tests with no piecelists, but also no check material draw also showed a (smaller) gain:
STC: http://chess.grantnet.us/viewTest/4612/
LTC: http://chess.grantnet.us/viewTest/4615/