Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hardwareKeyboardOnly flag to TerminalView #131

Merged
merged 5 commits into from
Sep 20, 2022

Conversation

tauu
Copy link
Contributor

@tauu tauu commented Sep 15, 2022

This PR adds a hardwareKeyboardOnly only flag to the TerminalView. If true, TerminalView will only listen for RawKeyEvents and not create an TextInputConnection. Its primary use case is to prevent the default on-screen keyboard being shown on mobile, in order to display a custom on screen keyboard. Listening for RawKeyEvents enables support for bluetooth keyboards or docked keyboards (e.g. iPad) while preventing the on-screen keyboard to be shown.

@tauu tauu changed the title feat: add hardwareKeyboardOnly feat: add hardwareKeyboardOnly flag to TerminalView Sep 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #131 (d397110) into master (07c1f17) will increase coverage by 13.06%.
The diff coverage is 72.72%.

@@             Coverage Diff             @@
##           master     #131       +/-   ##
===========================================
+ Coverage   38.31%   51.38%   +13.06%     
===========================================
  Files          49       50        +1     
  Lines        3226     3260       +34     
===========================================
+ Hits         1236     1675      +439     
+ Misses       1990     1585      -405     
Impacted Files Coverage Δ
lib/src/ui/keyboard_listener.dart 66.66% <66.66%> (ø)
lib/src/terminal_view.dart 67.44% <76.47%> (+8.32%) ⬆️
lib/src/terminal.dart 20.97% <0.00%> (+0.69%) ⬆️
lib/src/ui/custom_text_edit.dart 58.16% <0.00%> (+2.04%) ⬆️
lib/src/core/input/keytab/keytab_record.dart 4.54% <0.00%> (+4.54%) ⬆️
lib/src/core/input/keytab/keytab.dart 33.33% <0.00%> (+33.33%) ⬆️
lib/src/core/input/handler.dart 64.86% <0.00%> (+51.35%) ⬆️
lib/src/core/input/keytab/keytab_parse.dart 83.07% <0.00%> (+83.07%) ⬆️
lib/src/core/input/keytab/keytab_token.dart 90.24% <0.00%> (+90.24%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xtyxtyx xtyxtyx merged commit 0e10f22 into TerminalStudio:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants