Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.12.2 Crash #125

Closed
Basedgod199 opened this issue Sep 21, 2020 · 5 comments
Closed

1.12.2 Crash #125

Basedgod199 opened this issue Sep 21, 2020 · 5 comments
Labels
invalid other-mod Caused by another mod

Comments

@Basedgod199
Copy link

I thought it was ender up at fault but they say it's you:

SleepyTrousers/EnderIO-1.5-1.12#5437 (comment)

@TerminatorNL TerminatorNL added other-mod Caused by another mod invalid labels Oct 1, 2020
@TerminatorNL
Copy link
Owner

Please note this part:

    at com.enderio.core.common.TileEntityBase.TickCentral_TrueITickableUpdate(TileEntityBase.java:42)
    at com.github.terminatornl.tickcentral.api.TickHub.trueUpdate(TickHub.java:48)
    at com.github.terminatornl.laggoggles.Main.redirectUpdate(Main.java:91)
    at com.enderio.core.common.TileEntityBase.update(TileEntityBase.java)

The snippet above tells you that ender io initiates an update, LagGoggles wraps around to allow for timing of the function being called. LagGoggles in com does not alter ticking behavior like Tiquality does. I am sad to inform you that ender IO authors will have to re-diagnose this issue.

I suggest removing LagGoggles all togheter and wait for this bug to occur again, because it is definitely not LagGoggles

@HenryLoenwind
Copy link

BTW, may I direct you attention to this bit of code in World:

image

That update call already is wrapped in not one but two profilers. And you ASM in a third. It would be much simpler---and much less invasive---to assign your profiler to TimeTracker.TILE_ENTITY_UPDATE...

@TerminatorNL
Copy link
Owner

I was not aware forge added a time tracker. This could potentially be a very nice alternative to ASM transforming indeed. Please keep in mind my previous comment still stands, functionality wise.

@HenryLoenwind
Copy link

About the original issue: I usually don't trace stack traces through other mods' code but determine the state we are called in (world crashes when asked for TileEntity by itself) and hand over to the caller. I have no idea why World would crash when a TileEntity asks for itself by coordinates. And I don't really have an idea how to protect against that---the code that crashes already is the protection against unexpected weird world states:

image

@Honsal
Copy link

Honsal commented Oct 21, 2020

Hi. I had same issue, but THIS kind of issue, can be fixed with setting World.ITickable.Override to true in asm config file. At least, I was fixed it like this way.

However, this kind of issue(TerminatorNL/TickCentral/issues/13) was not fixed.

But in comment of that issue, @TerminatorNL uploaded an new TickCentral3.1 archive. I am using that and no probmel occurs on client.

Server is not yet tested, but I think it will be OK.

--- MODIFIED ---

It SEEMS like working, but actually no enderio machines are ticking.

Waiting for updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid other-mod Caused by another mod
Projects
None yet
Development

No branches or pull requests

4 participants