Comparator and Redstone interactivity #2262
Conversation
| // Sorry for this. | ||
| // This returns a unique analog value for every permutation of items within slots | ||
| @Override | ||
| public int getAnalogValue() |
There was a problem hiding this comment.
This just seems unintuitive to me, imo. Yes, in theory, people could use this to detect which element in a tool rack is present, but it makes much more sense to just output a count of the number of items in the tool rack.
| @Override | ||
| public void neighborChanged(BlockState state, Level level, BlockPos pos, Block block, BlockPos neighborPos, boolean s) | ||
| { | ||
| if (!level.isClientSide && level.hasNeighborSignal(pos)) | ||
| { | ||
| toggleSeal(level, pos, state); | ||
| } | ||
| } |
There was a problem hiding this comment.
Should barrels (which are pretty much definitionally a big pile o wood with no moving parts), actually react themselves to redstone signals? I'm on the fence for this, because I think comparator outputs are good and can be justified by "magic comparator block doing stuff" but idk, can "magic dust block doing stuff" also justify this?
@eerussianguy thoughts?
If it's contentious we could also add a config option for this doing anything (see #905)
|
|
||
| { | ||
| if (!level.isClientSide && level.hasNeighborSignal(pos)) | ||
| { | ||
| toggleSeal(level, pos, state); |
There was a problem hiding this comment.
Moreover, if we do add config options, one per device ("barrel reacts to redstone", "powderkeg reacts to redstone") I think would be good. For some reason I think the comparator output is a fairly no-brainer but the redstone input I could see being controversial.
| @Override | ||
| public int getAnalogOutputSignal(BlockState state, Level level, BlockPos pos) | ||
| { | ||
| return state.getValue(TYPE).ordinal(); |
There was a problem hiding this comment.
imo this should output STAGE, not TYPE ? I understand that makes it harder to automate, but it is more inline with what comparators do - measure the full-ness of things.
| @@ -365,6 +367,10 @@ | |||
| enablePlacingItems = builder.apply("enablePlacingItems").comment("If true, players can place items on the ground with V.").define("enablePlacingItems", true); | |||
| usePlacedItemWhitelist = builder.apply("usePlacedItemWhitelist").comment("If true, the tag 'tfc:placed_item_whitelist' will be checked to allow items to be in placed items and will exclude everything else.").define("usePlacedItemWhitelist", false); | |||
|
|
|||
| innerBuilder.pop().push("dispenser"); | |||
|
|
|||
| dispenserEnableLighting = builder.apply("dispenserEnableAutomation").comment("If true, dispensers will be able to light blocks.").define("dispenserEnableAutomation", true); | |||
There was a problem hiding this comment.
config value dispenserEnableLighting should match the name dispenserEnableAutomation
src/main/java/net/dries007/tfc/mixin/accessor/DispenserBlockAccessor.java
Outdated
Show resolved
Hide resolved
…cessor.java Co-authored-by: Alex O'Neill <35673674+alcatrazEscapee@users.noreply.github.com>
Co-authored-by: Alex O'Neill <35673674+alcatrazEscapee@users.noreply.github.com>
alcatrazEscapee
added
the
needs update
alcatrazEscapee
removed
the
needs update
This covers most of #2079, with the goal of comparators/dispensers giving players QoL improvements. This would allow players to automate most barrel recipes as well.
Fixes #2079