-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparator and Redstone interactivity #2262
Closed
Closed
Changes from 28 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
98046e7
add vessel & barrel redstone interaction
Charnuz fbed386
powderkeg & crucible redstone
Charnuz 80f590e
blast furnace & bloomery redstone
Charnuz a48198e
tool rack redstone & change barrel
Charnuz afc23d5
add quern redstone
Charnuz 1ded7aa
quern dispenser behavior
Charnuz 0414dfa
add lighting blocks with dispensers
Charnuz 380e5c1
fix infinite loop
Charnuz d240900
use lighting interface for event
Charnuz 5c4e6f7
blast furnaces lightable with dispensers
Charnuz c865aeb
bloomery lightable with dispensers
Charnuz 70726c8
lamps lightable
Charnuz 416fae6
powderkeg lightable
Charnuz 48fdace
fix infinite durability
Charnuz c5aa6dc
lighting torches
Charnuz 9a29d57
lightable firepits
Charnuz d1e1832
fix import issue
Charnuz 38a0a87
lightable candles
Charnuz 6555588
lightable log piles & pit kilns
Charnuz 36b3446
cleanup
Charnuz 1666d1a
nest box redstone
Charnuz 353f731
misc cleanup
Charnuz 0771c95
Merge branch '1.18.x' of https://github.com/TerraFirmaCraft/TerraFirm…
Charnuz 388cfc7
revert changes to StartFireEvent and remove Lightable
Charnuz d98bad0
add config option for dispenser lighting
Charnuz 8287006
i hate you IDEA
Charnuz 7766cb2
revert changes to StartFireEvent and remove Lightable
Charnuz 6337f50
Merge branch 'redstone' of https://github.com/Charnuz/TerraFirmaCraft…
Charnuz 7eef6c9
Update src/main/java/net/dries007/tfc/mixin/accessor/DispenserBlockAc…
Charnuz 74e131e
Update src/main/java/net/dries007/tfc/util/DispenserBehaviors.java
Charnuz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
src/main/java/net/dries007/tfc/common/blockentities/IAnalogInventory.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/* | ||
* Licensed under the EUPL, Version 1.2. | ||
* You may obtain a copy of the Licence at: | ||
* https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 | ||
*/ | ||
|
||
package net.dries007.tfc.common.blockentities; | ||
|
||
/** | ||
* Helper for containers that interface with comparators | ||
*/ | ||
public interface IAnalogInventory | ||
{ | ||
/** | ||
* @return the redstone analog value | ||
*/ | ||
int getAnalogOutput(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just seems unintuitive to me, imo. Yes, in theory, people could use this to detect which element in a tool rack is present, but it makes much more sense to just output a count of the number of items in the tool rack.