Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Discord links #23

Closed
ChloeDawn opened this issue Apr 19, 2019 · 7 comments
Closed

Suggestion: Discord links #23

ChloeDawn opened this issue Apr 19, 2019 · 7 comments
Labels
enhancement A new feature or improvement low priority Prioritized after other issues

Comments

@ChloeDawn
Copy link

Support for linking a discord server for a mod, or a discord account for an author.

"discord": "Username#0000"
"discord": "ServerId"

@Prospector
Copy link
Member

Prospector commented Apr 19, 2019

Where do you think a button for that should go? You also requested source links, where should that go? Small windows are already running out of space quickly, and I haven't even added dependencies yet
image

@Prospector Prospector added the enhancement A new feature or improvement label Apr 19, 2019
@asiekierka
Copy link

I'd say Discord URLs should take the form of an invite for "discord" and perhaps "discord-id" for user accounts, myself.

@ChloeDawn
Copy link
Author

Doesn't need a new schema, it would be new data not changed data

@ChloeDawn
Copy link
Author

And yeah, an invite would be more appropriate for servers, didn't think about that too much. I'm moreso interested in username metadata for contact info

@Prospector
Copy link
Member

Right now Mod Menu doesn't display any info for people though currently. Not sure how I would display it since it's mainly meant to show mods not authors

@sargunv
Copy link

sargunv commented Apr 24, 2019

Rather than specifically adding support for Discord links, why not just add generalized support for a custom list of links that gets appended to the description as a list of clickable blue links? No extra UI real-estate usage (it's just after the description in the scrollable pane), no locking people into discord (they may have some other form of community), and not much additional UI clutter (blue links "feel" less like part of the UI and more like content, unlike buttons).

@JustJinxed
Copy link

I'm not sure it needs a userid field per say, as some mods are maintained by a collection. but whateves.. The link to the discord server and/or website would be nice. Even if you have to pop a second window with a close button, and just call it, "more info"

@Prospector Prospector added the low priority Prioritized after other issues label Aug 12, 2019
Prospector added a commit that referenced this issue Feb 1, 2021
, Closes #135, Closes #149, Closes #183

- Major internal refactors
- Added links, contributors, and license information
- Added an options screen for Mod Menu
- Added a compact list mode option
- Added an options to change Mods button style to: Below Realms (Default), Shrink Realms, Replace Realms, and Fabric Icon
- Added an option to hide mod badges
- Added an option to move where the mod count is displayed (on button, on title screen, both, neither)
- Added options to specify whether or not to count libraries, children, and hidden mods in the mod count
- Added options to hide mod links, credits, or license info
- Added options to disable the modification of the title screen and/or game menu screen
- Changed the hardcoded icon for "java"
- Probably more that got forgotten about in this massive update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or improvement low priority Prioritized after other issues
Projects
None yet
Development

No branches or pull requests

5 participants