Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constraint extra geom is empty/valid #105

Merged
merged 4 commits into from
Apr 30, 2021
Merged

Conversation

LePetitTim
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #105 (74c5ed6) into master (0f22308) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   96.17%   96.17%           
=======================================
  Files          40       40           
  Lines        1831     1832    +1     
=======================================
+ Hits         1761     1762    +1     
  Misses         70       70           
Impacted Files Coverage Δ
geostore/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f22308...74c5ed6. Read the comment docs.

CHANGES.md Outdated
@@ -4,6 +4,10 @@ CHANGELOG
0.5.8.dev0 (XXXX-XX-XX)
---------------------------

!! WARNING - BREAKING CHANGES !!

* Add constraint extra geom empty / is_valid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Add constraint extra geom empty / is_valid
* Add constraint extra geom empty / is_valid. Check that your feature extra geometries are not empty or invalid before using this version

@LePetitTim LePetitTim merged commit aa2a155 into master Apr 30, 2021
@LePetitTim LePetitTim deleted the add_constraint_extrageom branch April 30, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants