Improve performance sync relations #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LePetitTim
force-pushed
the
fix_queryset_sync_relations
branch
from
1c7332d
to
dbe3da6
Compare
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
- Coverage 96.17% 96.17% -0.01%
==========================================
Files 40 40
Lines 1832 1831 -1
==========================================
- Hits 1762 1761 -1
Misses 70 70
Continue to review full report at Codecov.
|
LePetitTim
force-pushed
the
fix_queryset_sync_relations
branch
from
dbe3da6
to
68b9d53
Compare
jrmi
requested changes
Sep 14, 2021
geostore/models.py
Outdated
|
|
||
| logger.info(f"{to_delete.count()} element(s) to delete") | ||
| # logger.info(f"{to_delete.count()} element(s) to delete") |
There was a problem hiding this comment.
Do you need to keep this comments
geostore/models.py
Outdated
| logger.info(f"{len(qs)} element(s) to add") | ||
| qs = Feature.objects.filter(id__in=id_list).exclude(pk__in=self.relations_as_origin.filter(relation=rel) | ||
| .values_list('destination_id', flat=True)) | ||
| # logger.info(f"{len(qs)} element(s) to add") |
LePetitTim
force-pushed
the
fix_queryset_sync_relations
branch
from
68b9d53
to
d4b4b5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.