Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorize routing #43

Merged
merged 36 commits into from
Jun 26, 2020
Merged

Factorize routing #43

merged 36 commits into from
Jun 26, 2020

Conversation

submarcos
Copy link
Member

@submarcos submarcos commented Jan 27, 2020

  • pgRouting is not required anymore until you need routing features.
  • Factorization of all relating routing code to geostore.routing module
  • Allow custom tolerance usage in topology creation / update
  • Improve routing API response to include feature list
  • Add indexes on routing specific database columns
  • Improve documentation and set Makina Corpus theme

@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #43 into master will increase coverage by 0.09%.
The diff coverage is 97.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   95.75%   95.85%   +0.09%     
==========================================
  Files          38       40       +2     
  Lines        1720     1735      +15     
==========================================
+ Hits         1647     1663      +16     
+ Misses         73       72       -1     
Impacted Files Coverage Δ
geostore/routing/serializers/mixins.py 87.50% <87.50%> (ø)
geostore/routing/views/mixins.py 96.42% <95.45%> (+0.59%) ⬆️
geostore/models.py 98.31% <100.00%> (-0.01%) ⬇️
geostore/permissions.py 86.95% <100.00%> (+3.62%) ⬆️
geostore/routing/db/mixins.py 100.00% <100.00%> (ø)
geostore/routing/decorators.py 100.00% <100.00%> (ø)
geostore/routing/helpers.py 97.40% <100.00%> (+1.45%) ⬆️
...ore/routing/management/commands/update_topology.py 100.00% <100.00%> (ø)
geostore/serializers/__init__.py 97.33% <100.00%> (-0.07%) ⬇️
geostore/views/__init__.py 97.61% <100.00%> (+0.52%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a543af...d276dd5. Read the comment docs.

@submarcos submarcos marked this pull request as ready for review March 10, 2020 15:29
@submarcos submarcos merged commit 933455c into master Jun 26, 2020
@submarcos submarcos deleted the factorize_routing branch September 22, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant