Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub sup odt #65

Merged
merged 5 commits into from
Jun 22, 2022
Merged

Add sub sup odt #65

merged 5 commits into from
Jun 22, 2022

Conversation

LePetitTim
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #65 (03b6866) into master (40a6a1c) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   98.86%   99.10%   +0.23%     
==========================================
  Files          25       25              
  Lines        1413     1452      +39     
==========================================
+ Hits         1397     1439      +42     
+ Misses         16       13       -3     
Impacted Files Coverage Δ
template_engines/backends/odt.py 98.63% <100.00%> (+0.12%) ⬆️
template_engines/templatetags/odt_tags.py 98.09% <100.00%> (+0.13%) ⬆️
template_engines/tests/test_backends/test_odt.py 100.00% <100.00%> (ø)
..._engines/tests/test_template_tags/test_odt_tags.py 100.00% <100.00%> (ø)
template_engines/templatetags/utils.py 97.89% <0.00%> (+3.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40a6a1c...03b6866. Read the comment docs.

@@ -85,6 +85,32 @@ def get_automatic_style_underline(self, soup):
soup, style_attrs, text_prop_attrs
)

def get_automatic_style_sup(self, soup):
""" get style for underline """
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong doctstring ?

)

def get_automatic_style_sub(self, soup):
""" get style for underline """
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong doctstring ?

@@ -35,6 +35,26 @@ def parse_span(soup):
return soup


def parse_sup(soup):
""" Replace span tags with text:span """
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong doctstring ?



def parse_sub(soup):
""" Replace span tags with text:span """
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong doctstring ?

@codeclimate
Copy link

codeclimate bot commented Jun 22, 2022

Code Climate has analyzed commit 03b6866 and detected 8 issues on this pull request.

Here's the issue category breakdown:

Category Count
Security 8

View more on Code Climate.

@LePetitTim LePetitTim merged commit fa523dd into master Jun 22, 2022
@LePetitTim LePetitTim deleted the add_sub_sup_odt branch June 22, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants