Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#313] Setup Rubocop for Ruby #340

Closed

Conversation

rgenchev
Copy link
Contributor

@rgenchev rgenchev commented Oct 18, 2019

Closes #313

@auto-comment
Copy link

auto-comment bot commented Oct 18, 2019


Thank you for your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
Best,
@terrastories-stewards

@mirandawang
Copy link
Contributor

@rgenchev Thanks for the contribution!! Rubocop seems like it could be helpful. Can you describe more about what rules you're adding and what benefits you think they would bring? I'm wary to add too many rules that would block other people!

@mirandawang mirandawang added this to In progress in Ruby on Rails Tickets via automation Oct 21, 2019
@rgenchev
Copy link
Contributor Author

@rgenchev Thanks for the contribution!! Rubocop seems like it could be helpful. Can you describe more about what rules you're adding and what benefits you think they would bring? I'm wary to add too many rules that would block other people!

@mirandawang, sure. :)

I used what was discussed here: #313 (comment)

We use the default Rubocop configuration. We'll later work on 2 other PRs.

@FeminismIsAwesome
Copy link
Contributor

@rgenchev hi is this still being worked on? we just did a refactor that will require rebasing (moving the Rails app to a Rails directory)

@FeminismIsAwesome
Copy link
Contributor

Closing for now due to rebasing needs, can be reopened with those changes.

Ruby on Rails Tickets automation moved this from In progress to Done Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Tests] Setup StandardRB for Ruby
3 participants