Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

446 translating selected phrase #460

Merged
merged 10 commits into from Jul 1, 2020
Merged

Conversation

rudokemper
Copy link
Member

This is a supplementary PR for #446 that adds translation for selected in Matawai, Dutch, and Portuguese, and codes the parentheses into the helper file (rather than having them be in the i18n files).

@auto-comment
Copy link

auto-comment bot commented Jul 1, 2020


Thank you for your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
Best,
@terrastories-stewards

@rudokemper rudokemper merged commit f11b921 into master Jul 1, 2020
@rudokemper rudokemper deleted the 446-translating-selected-phrase branch July 1, 2020 22:37
Lukmin1999 pushed a commit to Lukmin1999/terrastories that referenced this pull request Jul 7, 2020
* Update pt.yml, nl.yml, mat.yml, en.yml, es.yml, ja.yml to remove parentheses from `language_select` and provide translation for Portuguese, Dutch and Matawai.

* Update application_helper.rb to add parentheses here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CMS] [i18n] Language picker should show selected language, not default language.
2 participants