Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(offline): prep and make adjustments for a smoother offline experience #970

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

lauramosher
Copy link
Contributor

  • Removed an unnecessary OFFLINE_MODE ENV in the prod Docker image. The default is always no, so listing it is not necessary.
  • Removed SECRET_KEY_BASE from default ENV in the prod Docker image. It's a required ENV, but should be managed by the image user, rather than an empty default set that we don't update later.
  • Removed asset-prefix in offline environment file: we don't compile assets using this environment, so we can share them with the default asset path.
  • Added a presence check for offline mode. In the event that SECRET_KEY_BASE var exists, but is empty, we auto-generate one for them rather than throwing an error.

@lauramosher lauramosher merged commit f2c4e0b into master Oct 5, 2023
@lauramosher lauramosher deleted the infra/offline-mode-adjustments branch October 5, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants