Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop openssl-legacy-provider parameter #664

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

pjonsson
Copy link
Contributor

Forcing terser-webpack-plugin to be version 4 alleviates the need for the --openssl-legacy-provider.

Use version 4 so node 18+ can be used
without --openssl-legacy-provider.
This is no longer required.
@pjonsson
Copy link
Contributor Author

@nf-s Is yarn install --frozen-lockfile && yarn upgrade, committing the new lock file, and then edit package.json+run yarn install how one is supposed to update package dependencies? And do I need to run these commands in node:16 image, or can I use the node:20 image just as well?

@ljowen ljowen self-requested a review April 8, 2024 04:18
@ljowen
Copy link
Contributor

ljowen commented Apr 8, 2024

@pjonsson Thanks for your contribution, that approach will work, you can also upgrade a specific dependency and version with yarn upgrade <package-name>@<version>. The lockfile will be used regardless of node version though it's good practice to test multiple version when upgrading a package

@ljowen ljowen merged commit 20a64b4 into TerriaJS:main Apr 8, 2024
3 checks passed
@pjonsson pjonsson deleted the node-18-compat branch April 8, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants