Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MobX Change detection (Delta) - v3 #4390

Closed
AnaBelgun opened this issue Jun 1, 2020 · 7 comments
Closed

MobX Change detection (Delta) - v3 #4390

AnaBelgun opened this issue Jun 1, 2020 · 7 comments

Comments

@AnaBelgun
Copy link
Member

This epic reflects design and development post user testing done on 19-21 May 2020.

@soyarsauce
Copy link
Contributor

soyarsauce commented Jun 10, 2020

Ana:

  • add the dates as part of the input steps (right now it's 3 steps, 1. layer, 2. display style, 3. output style, (4) location). make location show by default instead of appearing(?), and some placemarker for date being part of the input.
  • the dates remain at the bottom. Vic: but now there are labels to them. (Wing: Perhaps we put a date input in the steps that open the date picker?)

Nanda:

  • clicking a point on a map is for filtering dates.
    Ana: but by picking the point it lets you find the correct dates that apply to your region

Other feedback (marie/ana)
hard problem of "points representing a region":

  • showing point as a point rather than updating a region. e.g. tip of the location selector, showing this is for a region rather than the specific point.
  • for "filter by location", it's always for a region - the point is just to help filter for the region
  • dates at the bottom.

Vic: wants to ensure any steps moving forward w/ Delta have long term planning of how they all fit together

@AnaBelgun
Copy link
Member Author

19/06/2020
Latest Delta v3 design: https://projects.invisionapp.com/share/BXXRFD48YJ5#/screens

@soyarsauce
Copy link
Contributor

~Wed morning @na9da to pass delta off to Wing & Regina

@soyarsauce
Copy link
Contributor

@soyarsauce to clarify w/ @AnaBelgun on delta deliverables re: the two delta services, including the timeline for legend functionality

@AnaBelgun
Copy link
Member Author

AnaBelgun commented Jul 8, 2020

Considerations on legends' implementation. The challenge to tackle is to display 2 legends (legend 1 for initial imagery layer, and legend 2 for the result imagery layer). There are several options, depending on the service set up:

  1. show both legends separately as in Delta V3 design here https://projects.invisionapp.com/share/BXXRFD48YJ5#/screens;
  2. show one image with both legends: https://ows.dev.dea.ga.gov.au/legend/s2a_ard_granule_nbar_t/NBR/legend.png

Method 1: Use the advertised style legend url and pass the undocumented ndates parameter:
https://ows.dev.dea.ga.gov.au/legend/s2a_ard_granule_nbar_t/NBR/legend.png?ndates=1
image

https://ows.dev.dea.ga.gov.au/legend/s2a_ard_granule_nbar_t/NBR/legend.png?ndates=2
image

Method 2: Use the GetLegendGraphic method and pass the styles and date parameters, as you would do with GSKY which doesn't advertise a style legend url.

image

@soyarsauce
Copy link
Contributor

Critical thing left for this is the tangential relation of WMS legends in workbench
https://app.zenhub.com/workspaces/terria-frontend-ui-ux-5d802feb6b3dcf00019b6380/issues/terriajs/terriajs/4446

Nick is fixing

@soyarsauce
Copy link
Contributor

soyarsauce commented Sep 21, 2020

Remaining backlogged items in v4 #4644, can confirm blocked issues are resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants