-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story v2.0 - Placeholder routes for "new stories" via /stories/:id
#4692
Comments
In the first instance I wonder if you could do this with initialisation files and so http://maps.dea.ga.gov.au/#DEACoastlines would be the link, assuming you put an equivalent DEACoastlines.json in Not really my business, but potentially a good compromise for a September time constraint. If they can maintain their own catalogue. This is how the branch landing pages referred to in https://medium.com/terria/engineering-excellence-with-terria-douglas-partners-9da433753f23 are done |
Will update ticket description to clarify we aren't aiming for a url shortener in Terria @RussellGrew that's actually a good idea! If not for the fact that this will be utilising the story feature and not just a predefined catalog |
/stories/:id
As you may expect we are very happy to take receipt of this new feature. All good. Thanks for the response. |
Fantastic 🙂 @RussellGrew FYI points 1 & 2 on the issue description are updated now |
Hi @RussellGrew - yes you absolutely can, we used to do exactly that for AREMI in the past. If you use |
|
Blocked by #4961 |
/stories/:id
/stories/:id
/stories/:id
/stories/:id
Ana: need a conclusion for this ticket by march |
decision in team meeting to create static urls for stories so that customers (starting with DEA) can url shorten them and share them. Decision to not link this to SEO/route reserving. |
Ana: these share links will be created manually and curated and maintained by the Terria team. |
See draft here: #6151 Still deciding on route name (/story/{storyname} or /stories/{storyname}) and whether to immediately drop /story/{storyname} from the URL once the story loads, or whether to keep it (for page refreshes etc.) |
Connected to TerriaJS/TerriaMap#578 too |
both #6151 and TerriaJS/TerriaMap#578 have been merged |
Background:
DEA team would like to start using vanity url shortner for broadcasting work on some specific datasets.
The first example will be the use of the short url for the Coastlines data, to be published and disseminated to Government and other users in Sep.
There are 2 stages:
Once DEA team provides a share link with the story they want, we'll copy the contents of that share link into a cleaner s3 directory - remembering we prefix the first 2 characters into directories - https://github.com/TerriaJS/terriajs-server/blob/f2aa63e95debfdb4885ddacdfa7dffef2dde8d29/lib/controllers/share.js#L103. That way, we can make
https://maps.dea.ga.gov.au/#share=s-DEACoastlines
resolve to that share linkThe placeholder feature described in this actual ticket title - once the new routing in 1757 mobx new routing #4679 is merged, we will add an additional route under
/stories/:id
, which will form the basis of the new stories feature extensions. But the "placeholder" will simply resolve the:id
into a s3 share link under the same key (we do S3 here because realistically that's all we are using at the moment)1) enable the http://maps.dea.ga.gov.au/**#share=s-DEACoastlines** when DEA team advises the data publication and its url2) work and release a more elegant shortening of urls which will transform the above url closer to http://maps.dea.ga.gov.au/**DEACoastlines**The text was updated successfully, but these errors were encountered: