-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start migrating to gradle (non-working solution) #167
Conversation
Thanks for your help! I see this is still WIP, so I converted it to a draft. I’ll continue looking at this, please add commits if you do more work on this! |
Ofcourse! I'll try to make another commit tomorrow. |
…ixed some project java files in the process.
@SandwichBtw Please review the changes I made in the SandwichBtw-master branch to the Gradle files, and rebase them into your PR. They are in a working state now, and ready to be merged. However, I can't merge your PR without you rebasing first. If you need assistance please reach out via my Discord server, which is located in the project's README. I unfortunately cannot push any changes into this fork since it was based on the master branch of the project, and that branch is protected for a reason. Summary of changes:
I want to thank you for assisting with this PR so quickly. The project is building in ~5 seconds now, while with Maven was nearly 10 seconds. The only thing that needs configured is publishing, and that's something I must due for security reasons. Again, please rebase your PR and if you need assistance let me know. |
…tignore Add javadoc and sources to kotlin build Need to configure publishing to GitHub Packages / Maven repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
TODO:
|
I will fix it tomorrow but here is the start...