Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template: Clarify compensation #1130

Merged
merged 1 commit into from Jan 22, 2024

Conversation

InfoTeddy
Copy link
Collaborator

@InfoTeddy InfoTeddy commented Jan 22, 2024

Translators have been getting compensated for localization. Sometimes they submit pull requests for their changes, but just because they do doesn't mean that they won't get compensated.

The intent of this line was to make sure that any random contributor wouldn't expect any compensation for their changes, so adding another clause here still keeps that expectation while making it clear that it's not like @TerryCavanagh never compensates people. Even if, as a Swedish man once sung, "Terry is a monster, I think we all know that".

Legal Stuff:

By submitting this pull request, I confirm that...

  • My changes may be used in a future commercial release of VVVVVV
  • I will be credited in a CONTRIBUTORS file and the "GitHub Friends"
    section of the credits for all of said releases, but will NOT be compensated
    for these changes unless there is a prior written agreement

^^^ This is the updated line!

@flibitijibibo
Copy link
Collaborator

"... unless there is a prior written agreement" comes to mind, I guess it's implied but as with all agreements being more explicit always helps!

@TerryCavanagh
Copy link
Owner

"... unless there is a prior written agreement" comes to mind, I guess it's implied but as with all agreements being more explicit always helps!

yep, this is a good change!

Translators have been getting compensated for localization. Sometimes
they submit pull requests for their changes, but just because they do
doesn't mean that they won't get compensated.

The intent of this line was to make sure that any random contributor
wouldn't expect any compensation for their changes, so adding another
clause here still keeps that expectation while making it clear that it's
not like Terry _never_ compensates people. Even if, as a Swedish man
once sung, "Terry is a monster, I think we all know that".
@InfoTeddy
Copy link
Collaborator Author

Suggestion applied.

Copy link
Collaborator

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - will let Terry push the button since this is licensing-related!

@TerryCavanagh TerryCavanagh merged commit 67f5698 into TerryCavanagh:master Jan 22, 2024
@TerryCavanagh
Copy link
Owner

Done, thanks!

@InfoTeddy InfoTeddy deleted the general-doc-updates-2 branch January 22, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants