Cursor range, delete line bug, and support for top
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Implemented `CSI d` (set cursor vertical absolute) command, 2. Correctly deals with `CSI m` with no arguments (means reset all styles), 3. Correctly recognizes `ESC ( <rest>` (select G0 charset) and discard it. I don't think G0 charset selection will be needed in modern cases. Fixed #26.
TerryGeng
changed the title
top
|
Thank you. the problem had happened even while one editing the command but now it has resolved. But in this case there is another issue. for example, enter "Hello World" press left to place the cursor in front of 'o' and before the space. enter a character like 's'. press left again. Now instead of inserting a character between others, it replaces that with the new one. it looks like that the insert button on the keyboard is pressed (in summary inserting a character before a space causes toggling insert mode) |
|
Great! Thanks for your test. The new issue you are describing might be caused by one unimplemented escape sequence. It occurs even before the patches in #27. Would you please open a new issue for it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have fixed #26.