Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new and rename old params #446

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ceesios
Copy link
Contributor

@ceesios ceesios commented Jul 17, 2023

WIP: requires this pr to be merged first:

Add support for diff mode.

Renamed and added aliases to match vault api and HVAC names.

  • bind_dn = binddn
  • bind_pass = bindpass
  • discover_dn = discoverdn
  • group_attr = groupattr
  • group_dn = groupdn
  • group_filter = groupfilter
  • upn_domain = upndomain
  • user_attr = userattr
  • user_dn = userdn

Ordered documentation and parameters to prevent missing or duplicate parameters.

removed unsupported parameter "description"
ignore "use_pre111_group_cn_behavior" in read since it is undocumented and unsupported by HVAC.

add new parameters:

add diff mode support
@TerryHowe
Copy link
Owner

Hmm, this would require a major version bump

@ceesios
Copy link
Contributor Author

ceesios commented Jul 17, 2023

@TerryHowe are you sure this would require a major version bump? All parameters are aliased so it should be backwards compatible. And the use_pre111_group_cn_behavior and description were never in hvac for as far as i can see.

@TerryHowe
Copy link
Owner

Might be easiest to change this module to use one parameter like "configuration" and remove the dependency on the underlying implementation although this would have lest validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants