Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAP parsing + Buffered subtests seems to have a flaw #216

Open
exodist opened this issue Mar 9, 2021 · 0 comments
Open

TAP parsing + Buffered subtests seems to have a flaw #216

exodist opened this issue Mar 9, 2021 · 0 comments

Comments

@exodist
Copy link
Member

exodist commented Mar 9, 2021

# HARNESS-NO-STREAM
use Test2::V0;
use Test2::Tools::Subtest qw/subtest_streamed subtest_buffered/;

ok(1, "An ok");
diag "A Diag";
note "A Note";

subtest_streamed streamed => sub {
    ok(1, "streamed ok");
};

subtest_buffered buffered => sub {
    ok(1, "buffered ok");
};

done_testing;
( LAUNCH )  job  1    demo/tap/tap.t
(  NOTE  )  job  1    Seeded srand with seed '20210309' from local date.
[  PASS  ]  job  1  + An ok
(  NOTE  )  job  1    A Note
(  NOTE  )  job  1    Subtest: streamed
[  PASS  ]  job  1  +~Subtest: streamed
[  PASS  ]  job  1    + streamed ok
[  PLAN  ]  job  1    | Expected assertions: 1
            job  1    ^
[  PASS  ]  job  1  +~buffered
[  PASS  ]  job  1  +~buffered
[  PLAN  ]  job  1    Expected assertions: 3
(  NOTE  )  job  1    rss:  22732kB
(  NOTE  )  job  1    size: 31124kB
(  NOTE  )  job  1    peak: 31124kB
(  DIAG  )  job  1    A Diag
( PASSED )  job  1    demo/tap/tap.t
(  TIME  )  job  1    Startup: 0.01399s | Events: 0.00000s | Cleanup: 0.02992s | Total: 0.04391s

Notice that 'buffered' is displayed twice, and the nested events are not seen. The event log also has 'buffered' twice.

exodist added a commit that referenced this issue Mar 12, 2021
exodist added a commit that referenced this issue Mar 12, 2021
    - Add plugin support for providing coverage/duration data
    - Fix running t/integration tests with ./ in path (#215)
    - Add a fixme/todo test for #216 (Tap subtest parsing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant