Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all_items support in Bag #183

Merged
merged 1 commit into from Apr 26, 2019
Merged

Add all_items support in Bag #183

merged 1 commit into from Apr 26, 2019

Conversation

jjatria
Copy link
Contributor

@jjatria jjatria commented Apr 26, 2019

This patch adds support for all_items in bag builders.

Like with #177, this is the result of reaching for a feature and realising after the fact that it wasn't supported.

There are work-arounds to not having this, like

is \@array, meta {
    prop this => array { all_items $check; etc };
    prop this => bag { ... };
};

but that feels overly verbose, and I'm not clear on the rationale for not supporting this feature.

If there is a reason for this that I'm missing, we might want to add that to the docs and close this instead.

@exodist
Copy link
Member

exodist commented Apr 26, 2019

Thanks!

@exodist exodist merged commit c3bab50 into Test-More:master Apr 26, 2019
@jjatria
Copy link
Contributor Author

jjatria commented Apr 26, 2019

Thank you! :D

@jjatria jjatria deleted the all-items-bag branch April 26, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants