Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHROMATIC/SUPER-1.20120705.tar.gz fails with _071 #476

Closed
andk opened this issue Nov 2, 2014 · 3 comments
Closed

CHROMATIC/SUPER-1.20120705.tar.gz fails with _071 #476

andk opened this issue Nov 2, 2014 · 3 comments

Comments

@andk
Copy link

andk commented Nov 2, 2014

Sample fail report:

http://www.cpantesters.org/cpan/report/16328436-62a0-11e4-9e2c-108fbb36d621

The report was written with _070 but I saw fails with _071 as well

@exodist
Copy link
Member

exodist commented Nov 3, 2014

I have not loomed at the test, but I suspect it is checking that Test::Builder::Module isa Exporter. If that is the case then I would argue that the author should define their own package for the test instead of relying on an external module he does not control to never change how it works under the hood. That is just poor testing practice.

However I can't be sure until I get to a computer and verify.

@exodist
Copy link
Member

exodist commented Nov 4, 2014

ok, the test at issue:

is( Test::Builder::Module->super( 'import' ),
    \&Exporter::import, '... as does Test::Builder::Module' );

Test::More is no longer using Exporter.pm, and switching back is not an option for me. SUPER should have mocked out it's own packages to test against, ones it can control.

I will open an issue on that module.

@exodist exodist closed this as completed Nov 4, 2014
@exodist
Copy link
Member

exodist commented Nov 4, 2014

looks like it was already reported 3 months ago, no action has been taken

https://rt.cpan.org/Ticket/Display.html?id=97939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants