Remove abusefilter-private from oversight #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See my comments here. |
MacFan4000
pushed a commit
that referenced
this pull request
Jan 9, 2021
Needs to be a real path, not relative one 6) FileTest::testGetThumbnailSource with data set #2 (array(true, array('/tmp'), 1024, 2048, '/tmp', 'Temporary path because temp f... found')) Temporary path because temp file was found Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'/tmp' +'fsFilePath' The file_exists in File::getThumbnailSource gets the path '/tmp' and that does not exists on windows, because it is relative to one of the core folder Change-Id: I8618c8b34261451da42f88360a9d65353960e91f (cherry picked from commit 8f80236)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Task T21