Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Magellan Executor #206

Merged
merged 41 commits into from Mar 9, 2017
Merged

Magellan Executor #206

merged 41 commits into from Mar 9, 2017

Conversation

archlichking
Copy link
Contributor

support executors to run test in a more delicate way.

what is an executor

  1. middle layer between magellan and test framework
  2. bridge to connect magellan and plugins

what can an executor do

  1. resolve profiles (env info, test info, capabilities for selenium test)
  2. patch setup and teardown event on the magellan test runner
  3. patch setup and teardown event on a magellan worker
  4. do some extra work in test's lifecycle
  5. communicate to a specific test env

@geekdave @Maciek416

@codecov-io
Copy link

codecov-io commented Mar 8, 2017

Codecov Report

Merging #206 into master will increase coverage by 0.78%.
The diff coverage is 98.39%.

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage    97.9%   98.69%   +0.78%     
==========================================
  Files          30       28       -2     
  Lines        1384     1147     -237     
  Branches      262      191      -71     
==========================================
- Hits         1355     1132     -223     
+ Misses         29       15      -14
Impacted Files Coverage Δ
src/test.js 100% <100%> (ø)
src/help.js 100% <100%> (ø)
src/logger.js 100% <100%> (ø)
src/cli_help.js 100% <100%> (ø)
src/util/load_relative_module.js 100% <100%> (ø)
src/worker_allocator.js 100% <100%> (ø)
src/settings.js 100% <100%> (ø)
src/util/process_cleanup.js 100% <100%> (ø)
src/util/check_ports.js 96.42% <100%> (-3.58%)
src/profiles.js 97.22% <97.22%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df322d...a4a68c0. Read the comment docs.

Copy link
Contributor

@Maciek416 Maciek416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple corrections, LGTM otherwise. Epic! 👍

README.md Outdated
------------------**BREAKING CHANGE in v10.0.0**------------------
### Magellan Executor

Executor is a mid layer between magellan and test framework to drive test run (via framework) based on a specific need (differentiated by executing environments). Magellan doesn't provide a default executor, so you need to pick at least one executors from the existing executor list, or implement one yourself.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to pick at least one executor

README.md Outdated

Executor is a mid layer between magellan and test framework to drive test run (via framework) based on a specific need (differentiated by executing environments). Magellan doesn't provide a default executor, so you need to pick at least one executors from the existing executor list, or implement one yourself.

what is an executor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format as a sub-heading

README.md Outdated
1. middle layer between magellan and test framework
2. bridge to connect magellan and plugins

what can an executor do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format as a sub-heading

README.md Outdated
- https://github.com/TestArmada/magellan-mocha-plugin

Boilerplate / example projects:
BREAKING CHANGE: magellan@10.0.0 doesn't support mocha plugin for now. If you're using magellan version 9 or lower to run mocha test please don't upgrade. Or if you're seeking for mocha support please use magellan version 9 or lower.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mocha plugin

@archlichking archlichking merged commit 7a8d13a into master Mar 9, 2017
@JoseInTheArena JoseInTheArena deleted the executor branch August 5, 2020 05:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants