Remove NRE when changing ShowCheckBoxes #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
Note, I've decided not to update the setting
TestTreeSettings.ShowCheckBoxes
when changingShow CheckBoxes
via the menu or via the context menu. This can be done viaModel
, if we choose so. The reason for this, is it seems that most changes in menus do not update the "default" settings inTools => Settings
(except for Full GUI vs Mini GUI).Also note that we do not change the user interface, if we change the setting
TestTreeSettings.ShowCheckBoxes
. This will first have effect when we restart the program. We could do this by commenting in the methodUserSettings_Changed
(and do some more changes), but it does not seem like we update the UI immediately when changing settings inTools => Settings
.So before making the above mentioned changes I think we should decide upon the connection between the settings in
Tools => Settings
and settings we can set directly in the GUI (in menus and context-menues). I think of them as the "default" vs. the "current" settings, but it can be that this is just my interpretation.