Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NRE when changing ShowCheckBoxes #53

Merged
merged 1 commit into from Jun 14, 2018

Conversation

mikkelbu
Copy link
Contributor

@mikkelbu mikkelbu commented Jun 9, 2018

Fixes #52

Note, I've decided not to update the setting TestTreeSettings.ShowCheckBoxes when changing Show CheckBoxes via the menu or via the context menu. This can be done via Model, if we choose so. The reason for this, is it seems that most changes in menus do not update the "default" settings in Tools => Settings (except for Full GUI vs Mini GUI).

Also note that we do not change the user interface, if we change the setting TestTreeSettings.ShowCheckBoxes. This will first have effect when we restart the program. We could do this by commenting in the method UserSettings_Changed (and do some more changes), but it does not seem like we update the UI immediately when changing settings in Tools => Settings.

So before making the above mentioned changes I think we should decide upon the connection between the settings in Tools => Settings and settings we can set directly in the GUI (in menus and context-menues). I think of them as the "default" vs. the "current" settings, but it can be that this is just my interpretation.

@CharliePoole
Copy link
Contributor

@mikkelbu I agree with both what you have done and what you suggest we need to look into. I have started writing a sort of spec about how this should work and which settings take precedence.

Since this project is a look-alike of the old NUnit Gui, I often run that in order to see what it does in a particular case.

Anyway, merging this and we can change more in a follow-up PR. I'm working on a more general one to do with settings organization right now.

@CharliePoole CharliePoole merged commit 7f309e1 into TestCentric:master Jun 14, 2018
@mikkelbu mikkelbu deleted the issue52 branch June 14, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants