Merge pull request #233 from hastebrot/refactor-improve-encapsulation

(refactor) Improve encapsulation of classes.
TestFX · Nov 19, 2015 · 719f21a · 719f21a
2 parents 7037725 + e7fdd7b
commit 719f21a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/subprojects/testfx-core/src/main/java/org/testfx/api/FxAssert.java b/subprojects/testfx-core/src/main/java/org/testfx/api/FxAssert.java
@@ -28,7 +28,7 @@
 import org.testfx.service.query.NodeQuery;
 
 @Unstable(reason = "method signatures need fine-tuning")
-public class FxAssert {
+public final class FxAssert {
 
     //---------------------------------------------------------------------------------------------
     // CONSTANTS.
@@ -48,7 +48,7 @@ public class FxAssert {
 
     // ASSERTIONS: SUPER MATCHER.
 
-    @Unstable(reason = "is missing apidocs")
+    @Unstable(reason = "is missing apidocs; might be removed due to complications with generics")
     public static <T> void verifyThat(T value,
                                       Matcher<? super T> matcher) {
         verifyThatImpl(emptyReason(), value, matcher);

diff --git a/subprojects/testfx-core/src/main/java/org/testfx/api/FxService.java b/subprojects/testfx-core/src/main/java/org/testfx/api/FxService.java
@@ -19,7 +19,7 @@
 import org.testfx.api.annotation.Unstable;
 
 @Unstable(reason = "class was recently added")
-public class FxService {
+public final class FxService {
 
     //---------------------------------------------------------------------------------------------
     // STATIC FIELDS.

diff --git a/subprojects/testfx-core/src/main/java/org/testfx/api/FxToolkit.java b/subprojects/testfx-core/src/main/java/org/testfx/api/FxToolkit.java
@@ -94,7 +94,7 @@
  * in the JavaFX thread. The primary Stage is constructed by the platform.</p>
  */
 @Unstable(reason = "class was recently added")
-public class FxToolkit {
+public final class FxToolkit {
 
     //---------------------------------------------------------------------------------------------
     // STATIC FIELDS.

diff --git a/subprojects/testfx-core/src/main/java/org/testfx/robot/impl/TypeRobotImpl.java b/subprojects/testfx-core/src/main/java/org/testfx/robot/impl/TypeRobotImpl.java
@@ -97,14 +97,14 @@ private void pushKeyCode(KeyCode keyCode) {
         keyboardRobot.release(keyCode);
     }
 
-    public void pushKeyCodeCombination(KeyCode... keyCodeCombination) {
+    private void pushKeyCodeCombination(KeyCode... keyCodeCombination) {
         List<KeyCode> keyCodesForwards = Lists.newArrayList(keyCodeCombination);
         List<KeyCode> keyCodesBackwards = Lists.reverse(keyCodesForwards);
         keyboardRobot.pressNoWait(toKeyCodeArray(keyCodesForwards));
         keyboardRobot.release(toKeyCodeArray(keyCodesBackwards));
     }
 
-    public void pushKeyCodeCombination(KeyCodeCombination keyCodeCombination) {
+    private void pushKeyCodeCombination(KeyCodeCombination keyCodeCombination) {
         List<KeyCode> keyCodes = filterKeyCodes(keyCodeCombination);
         pushKeyCodeCombination(toKeyCodeArray(keyCodes));
     }