Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) ListViewMatchers: Add isEmpty(). #251

Merged
merged 2 commits into from Mar 14, 2016
Merged

Conversation

brcolow
Copy link
Collaborator

@brcolow brcolow commented Mar 7, 2016

Although one could get the same functionality as isEmpty() using:

FxAssert.verifyThat(someListView, ListViewMatchers.hasItems(0));

it better conveys what we are trying to assert/test by using:

FxAssert.verifyThat(someListView, ListViewMatchers.isEmpty());

brcolow and others added 2 commits March 6, 2016 18:30
Although one could get the same functionality as isEmpty() using:

FxAssert.verifyThat(someListView, ListViewMatchers.hasItems(0));

it better conveys what we are trying to assert/test by using:

FxAssert.verifyThat(someListView, ListViewMatchers.isEmpty());
@hastebrot hastebrot changed the title Add isEmpty() method to ListViewMatchers and add tags to gitignore. (feat) ListViewMatchers: Add isEmpty(). Mar 14, 2016
hastebrot added a commit that referenced this pull request Mar 14, 2016
(feat) ListViewMatchers: Add isEmpty().
@hastebrot hastebrot merged commit 90b3fb0 into TestFX:master Mar 14, 2016
@hastebrot
Copy link
Member

Thanks, for adding the matchers!

@hastebrot
Copy link
Member

An alternative method name could be hasZeroItems() to avoid any confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants