Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) ApplicationService: Use Application instead of ApplicationFixture. #257

Merged
merged 3 commits into from Mar 27, 2016

Conversation

hastebrot
Copy link
Member

  • Use Application (instead of ApplicationFixture) in ApplicationService and FxToolkit.
  • Move ApplicationFixture and ApplicationAdapter from testfx-core to testfx-junit.

This changes ApplicationAdapter to extend Application instead of implementing ApplicationFixture. We need a ApplicationFixture interface in testfx-junit to let ApplicationRule extend FxRobot (single inheritance of Java).

// before.
class ApplicationAdapter implements ApplicationFixture {}

// after.
class ApplicationAdapter extends Application {}

cc: @johnzeringue (this should not affect the behaviour of ApplicationRule).

@hastebrot
Copy link
Member Author

This also allows us to implement a complete ApplicationServiceImplTest.

@hastebrot hastebrot merged commit cd83eb5 into TestFX:master Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant