(fix) Add check to cleanup for active FX Application Thread. #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 27, 2016 17:03
Task-Url: http://github.com/TestFX/TestFX/issues/issue/287 Added method to detect whether FX Application Thread is running. Clean up code is only pushed on the FX-Thread if it is running. fixes TestFX#287 fixes TestFX#247
Task-Url: http://github.com/TestFX/TestFX/issues/issue/287 Removed extra method waitForCleanup. Query isFXApplicationThreadRunning directly from the cleanup method, so nothing gets called. Throw TimeoutException if not running.
|
Modified the solution a bit: TimeoutException will be thrown if FX Application Thread is not running. This may better match the current behaviour if stuck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
see #287 and #247
Solution
Added method
isFXApplicationThreadRunning()inFxToolkitto detect whether FX Application Thread is running. Clean up code is only pushed on the FX-Thread if it is running.fixes #287
fixes #247