Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add javadoc to util package #328

Merged
merged 3 commits into from Dec 3, 2016
Merged

Add javadoc to util package #328

merged 3 commits into from Dec 3, 2016

Conversation

JordanMartinez
Copy link
Contributor

No description provided.

@JordanMartinez
Copy link
Contributor Author

As I was going through this... why does PointQueryUtils#atPositionFactors pass in lerp(bounds.getMinX(), bounds.getMaxX(), positionFactors.getX())? Shouldn't the second argument be bounds.getWidth() as that's what is calculated in lerp?

@JordanMartinez
Copy link
Contributor Author

This PR is now done.

@JordanMartinez JordanMartinez changed the title Add javadoc to service util package Add javadoc to util package Dec 3, 2016
@JordanMartinez JordanMartinez mentioned this pull request Dec 3, 2016
Merged
@brcolow brcolow merged commit 5975d85 into TestFX:master Dec 3, 2016
@brcolow
Copy link
Collaborator

brcolow commented Dec 3, 2016

Merged. Thanks a lot!

@JordanMartinez JordanMartinez deleted the documentUtils branch December 3, 2016 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JordanMartinez @brcolow