Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document FxRobotInterface #331

Merged
merged 1 commit into from Dec 18, 2016
Merged

Document FxRobotInterface #331

merged 1 commit into from Dec 18, 2016

Conversation

JordanMartinez
Copy link
Contributor

No description provided.

@JordanMartinez
Copy link
Contributor Author

There's one issue I find with this: one has to lookup the javadoc of the actual method and then look at the method it calls to actually see what it does. Otherwise, one would have to update two places of documentation.

Should this javadoc-by-referral be the case? Or should the javadoc be transferred from the [Action]Robot interface to the FxRobotInterface?

@brcolow
Copy link
Collaborator

brcolow commented Dec 5, 2016

I think the documentation should be on the highest point up the inheritance chain, and then the documentation will be automatically @Inherited, for cases where we are not talking about implementing an interface or abstract class, we can use @see org.testfx.Class#method to keep the docs in one place.

If that principle still doesn't answer your specific concern, can you show me an example? Thanks.

@JordanMartinez
Copy link
Contributor Author

I think the documentation should be on the highest point up the inheritance chain, and then the documentation will be automatically @inherited,

Right.

For cases where we are not talking about implementing an interface or abstract class, we can use @see org.testfx.Class#method to keep the docs in one place.

I believe this answers my question, which I interpret as "Continue doing as you've done."

On a separate note, I realize the wording on my second commit could be misunderstood to mean "I removed the @Unstable annotation." I'll need to fix that when I have time to do so.

@JordanMartinez
Copy link
Contributor Author

This is still a WIP

@JordanMartinez JordanMartinez changed the title Document FxRobot Document FxRobotInterface Dec 8, 2016
@JordanMartinez
Copy link
Contributor Author

Still a WIP, though it'll be done probably within 2 days because I'll be busy tomorrow and the following day's morning.

@JordanMartinez
Copy link
Contributor Author

K. This should be done now. Look it over and let me know if I need to make any changes anywhere.

@brcolow brcolow merged commit 5e2bb85 into TestFX:master Dec 18, 2016
@brcolow
Copy link
Collaborator

brcolow commented Dec 18, 2016

:> -- awesome. Thanks so much!

@JordanMartinez JordanMartinez deleted the fxRobot branch December 19, 2016 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants