Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc toolkit package #339

Merged
merged 4 commits into from Dec 18, 2016
Merged

Doc toolkit package #339

merged 4 commits into from Dec 18, 2016

Conversation

JordanMartinez
Copy link
Contributor

Assuming checks pass, this is done.

@JordanMartinez
Copy link
Contributor Author

Well, PrimaryStageFuture could be documented, but it's essentially just a Future that can run listeners after it is set. If people follow the javadoc trail of its subclasses, they'll figure that out. So, I'm not sure if that class really needs to be documented.

@brcolow brcolow merged commit a169fe9 into TestFX:master Dec 18, 2016
@brcolow
Copy link
Collaborator

brcolow commented Dec 18, 2016

Looks good to me, Appveyor failure is just flakiness (obviously as this is only comments :)). Thanks a ton.

@JordanMartinez JordanMartinez deleted the docToolkitPackage branch December 19, 2016 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JordanMartinez @brcolow