Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc api package #341

Merged
merged 7 commits into from Dec 20, 2016
Merged

Doc api package #341

merged 7 commits into from Dec 20, 2016

Conversation

JordanMartinez
Copy link
Contributor

WIP

@JordanMartinez
Copy link
Contributor Author

The only object left to document in this PR is the FxAssert class. However, it is annotated with @Unstable because "method signatures need fine-tuning." I feel like that should be resolved before writing any documentation. Otherwise, the first draft of documentation may become outdated once these method signatures are refined.

@brcolow
Copy link
Collaborator

brcolow commented Dec 20, 2016

Sounds good to me. Does that mean this is ready?

@JordanMartinez
Copy link
Contributor Author

yeah. It's ready.

@JordanMartinez
Copy link
Contributor Author

actually, let me fix that previous commit message...

@JordanMartinez
Copy link
Contributor Author

Ok. Now it's ready once tests pass.

@brcolow brcolow merged commit 65b4075 into TestFX:master Dec 20, 2016
@brcolow
Copy link
Collaborator

brcolow commented Dec 20, 2016

Thanks!

@JordanMartinez JordanMartinez deleted the docAPIPackage branch December 20, 2016 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JordanMartinez @brcolow