(refactor) Moved ShortcutKeyTest to core package.
#342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanMartinez
force-pushed
the
refactorShortcutTest
branch
from
9922703
to
f12fe61
Compare
|
Awesome. Makes sense. Thanks. |
|
@brcolow When I look at the commit history of this project (not this PR), this commit appears with an "x" next to it because all the tests in |
|
It is only flakiness. This is verified by later commits having green checkmarks. Those failures are quite hard to reproduce reliably and have something to do with headless macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that I have a better understanding of how the core package works, I thought this test should be moved to its actual package since its an implementation detail.
The other test I wrote,
KeyAndButtonReleaseTest, seems like it should stay in its respective packages as those packages have classes used for testing. Thus, hang-prevention should already be a part of them.