Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests of jUnit5 adapter #347

Merged
merged 2 commits into from Jan 12, 2017
Merged

Fix tests of jUnit5 adapter #347

merged 2 commits into from Jan 12, 2017

Conversation

SimY4
Copy link
Contributor

@SimY4 SimY4 commented Jan 1, 2017

Aparently no tests were executed during gradle build for junit5 tests (my bad, sorry). At this point junit5 tests require sepcial gradle plugin for tests discovery. I've added that plugin and fixed couple of issues with current test scenarios.

@brcolow
Copy link
Collaborator

brcolow commented Jan 1, 2017

Hmm..thanks for this. I am confused because this is the first time I have seen the legacy TestFX tests fail in this way:

org.loadui.testfx.AssertionsTest > classMethod FAILED
    java.awt.AWTError: Can't connect to X11 window server using ':99.0' as the value of the DISPLAY variable.

This has happened twice in a row. However I am quite certain it is not related to this PR as the TestFX legacy project is not altered by this PR.

@brcolow
Copy link
Collaborator

brcolow commented Jan 2, 2017

Are the test failures related to this PR?

@SimY4
Copy link
Contributor Author

SimY4 commented Jan 2, 2017

Hmm... No, I don't think that they are related. Junit5 adapter have exact copies of jUnit4 adapter tests. Can this be related to recent changes in travis CI?

@brcolow
Copy link
Collaborator

brcolow commented Jan 3, 2017

Hmm this is really quite strange because travis is able to build master as it is now on the new infrastructure:

https://travis-ci.org/TestFX/TestFX/jobs/188453444

So I am not sure what is going on.

@brcolow
Copy link
Collaborator

brcolow commented Jan 3, 2017

Apparently these changes are okay if one skips the testfx-legacy tests from running in the build:

#349

I really don't understand why adding these changes causes the legacy tests to fail.

@JordanMartinez
Copy link
Contributor

What if you remove the KeyAndButtonReleaseTest since that test does need to be run in a fixed order? Is it possible that that test might be interfering with others?

@brcolow
Copy link
Collaborator

brcolow commented Jan 12, 2017

It failed, but I restarted it and it passed. Something is super flaky...but I think this is an improvement. Besides, using the new Travis CI cron builds even master is intermittently failing. Merged. Thanks!

@brcolow brcolow merged commit 5e4aef7 into TestFX:master Jan 12, 2017
@SimY4 SimY4 deleted the junit5-test-fixes branch January 12, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants